The following guns were used in the film Valkyrie:
Valkyrie is the modern telling of the plot to kill Hitler. The main character is decorated war hero and senior German army officer Colonel Claus von Stauffenberg (Tom Cruise). The plot to place a bomb underneath the table where Hitler is meeting his generals is a well known historical story. What is not often known is that this was one of 20 known attempts on Hitler's life by his own military. Apparently more than a few Germans saw the evil that was their leader.
Seen in many of the massing army sequences, in Berlin and in North Africa, the Karabiner 98k is the most commonly seen firearm in the film, and is used by much of the Nazi soldiers.
Walther PPK
Colonel Claus von Stauffenberg (Tom Cruise), as well as most of the German officers use Walther PPKs as their sidearms, most notably General Ludwig Beck (Terence Stamp) and Major Otto Ernst Remer (Thomas Kretschmann).
MP40
Many of the Wehrmacht soldiers are seen carrying MP40 submachine guns.
MG42
An MG42 is seen briefly when the Home Guard is mobilized during Operation Valkyrie. One is also carried by a D.A.K. (Afrika Korp) soldier in North Africa.
MG34
MG34s are seen briefly being used by the military guards surrounding the forests leading to "The Wolf's Lair" (Hitler's Prussian Field Bunker).
Walther P38
Surprising seen very little, mostly in the hands of SS or Polizei officers.